Reply To: MWEdit
Fixed the WinSock2 errors. Had to add WIN32_LEAN_AND_MEAN to the definitions in the build script. It didn’t work in the code but that may been due to include order (which is still being worked on). The build script will need some cleaning up at some point, more than likely. It’s already on the tracker 🙂
Still working through getting the debug build working.
Edit:
We’re getting closer. There’s at least one error buried somewhere in the 25,000-line build log. Could do a search for it but, even then, it’ll be hard to spot among all of the warning noise.
Looks like it’s complaining about mwedit/script_options.h now when it was fine before. I added the necessary Windows includes but still no luck. It’s complaining about syntax errors but I’m not seeing them. It could be something with the macros. Any ideas? I may merge it into master and see what happens on a release build as it didn’t happen before debug builds were turned on and I started messing with the file paths. I’ll start by doing a direct comparison though that may fail due to the file name changes.
Edit 2:
I was afraid of that. The diff fails between master and dev due to the changes to the file names. May do a test commit with release instead of debug on the dev branch or I may create a new branch so I don’t mess up master… :/
Test branch using Release config comes up with different errors: https://github.com/deathssoul/MWEdit/actions/runs/21091754553/job/60663963134
Weird. Going to start trying to sort through them. Not sure what’s going on here but it looks like we’re dealing with some Windows breakage. Could also be due to WIN32_LEAN_AND_MEAN. Whelp. Will add all of the missing includes it’s complaining about on Release and will go from there and hopefully Debug will get fixed in the meantime.
Maybe this is a good opportunity to go back to adding all of the missing includes?
Working on adding them. Previously, the project was set up in VS to implicitly add the stdafx.h file to each instead of explicitly so several files were missing it. Changing the project structure somehow triggered it crapping out without the explicit includes for some reason. Maybe due to how VS works, not sure. Normally, the compiler would crap out regardless. In any case, I’m going through and adding the missing Windows includes that are necessary for building on Release. Hopefully that’ll also fix Debug but we’ll revisit that once I get these issues fixed. We’ll be moving away from a stdafx.h file in favor of more explicit definitions so that we have a better handle on what’s going on and for better portability.