There are two sets of CreaturePage files in ui/: those with the Esm prefix and those without. The ones without don’t appear to have their classes used in the project but the files are included in the ones with the prefix. Both make heavy use of the MFC code generation stuff so it’s a little hard to tell if the ones without the prefix are actually being used in the project. For now, I won’t rename the ones with the prefix but we’ll definitely want to sort this out at some point as it’s really confusing.
For example:
CCreaturePage1 defines a new dialogue property, IDD_CREATURE1_VIEW, which is then mapped to number 137 in ui/Resource.h. This property isn’t used elsewhere and the class doesn’t define any other properties. Also, the file uses a weird header guard compared to the file with the prefix so it appears to have been redone but not removed at some point in the past and then included in the new file for whatever reason. Based on this reasoning, it sounds like it may be safe to tag these redundancies for removal? We’ll want to make a not of the stuff they add to the resource files as well if that’s the case so that we can make sure we catch everything. We’ll want to clean up the resource files anyways at some point so that they’re more manageable. The source files are also pretty much empty so I think we can safely tag them for removal
