Thanks. 🙂
Ultimately, they’ll be swapped out when we switch GUI toolkits but we can revisit things then 🙂
Looked at it more closely and ON_WM_TIMER() is supposed to map to an UINT_PTR while the code is trying to use just UINT. Probably a change in MFC signatures at some point over the last couple of decades. That fixed that error when I changed the type. Got some more, which isn’t unexpected. It was able to work through 92 files this time so we’re definitely getting closer. There will be more const types to correct but I’ll let it point me to them so I don’t have to go on a treasure hunt 🙂
Yeah, I’m not entirely sure what all of the stuff in Common is for. It could be for other projects totally unrelated to the community as I haven’t seen it used anywhere else. With the time stuff, he’s using it to profile stuff in debug mode and in general in the script compiler but those all use dl_time instead. Lately, he’s pretty focused on admin duties at UESP but does update the Edit code from time to time for compatibility. He even added some stuff to it for Starfield in a separate repository. 🙂
Edit:
We’re getting some pointer truncation warnings in project/mwrecordmap.h that are annoying to see in the log so I’ll look at fixing them up at some point. Just tired of seeing them 😛
Still working through compatibility errors. It’s also caught some missing includes, which is nice. Once it’s building, I’ll clean things up a tad before squashing the commits and merging 🙂
