Activity

Yeah, comments may help. I’ll definitely want a good review once I get the whitespace pushed up in a few days. 🙂

Astyle took care of the mixture of tabs and spaces for indentation a few months ago but I always turn on whitespace viewing in my editor to make sure nothing creeps in. I like to use tabs for indentation as everyone has different…[Read more]

The #defines in project/EsmScriptFuncs.cpp could also remain short with the long defs as a comment. Although they do seem to be quite at home in EsmScriptDefs.h, in case of being used elsewhere. Using static constexpr might be a thing, macros are cheaper in the preprocessor – there may only be a minimal difference.
Ok, as you know, horizontal…[Read more]

On a similar note, the descriptions for the resistance functions just say things along the lines of, “Get resistance”. They should probably include the stat that they are resisting in the description for completeness

Side note: this is going to be a huge commit when I’m done with the whitespace in this directory. 😛

Saw Moon the other day and it was pretty well done. The limited amount of characters helped a lot as it kept the film was losing focus.

Not sure if it’s the same cut that I saw but it looks to be the same film 🙂

Yeah, that is an odd coincidence. Usually, they take stage names to keep their names from getting confused like that.

Saw…[Read more]

Yeah, we’ll definitely want to expand on the function descriptions to explain why something is broken.

Elsewhere, a compiled help file is referenced but there doesn’t seem to exist any file that sets one up in the repository so more digging is probably needed. It may be using the one in the original CS, which would be strange as MWEdit is a…[Read more]

“Broken” inspires only a piddle of confidence, might be worthwhile adding a ref. either to the issue or as a new issue with a “related” tag.
Back to the macros:

/* Shorter definitions for convienence */

It’s more of a conveyance of long to short if you will, the main issue being the byte size of the cpp to increase dramatically when…[Read more]

Yes, watched Moon some time ago, intriguing and well filmed despite a depressing outcome. Not because of the film, but of the humanity of the content thereof – you’re sure to discover. 🙁
Is that the same as the “full HD” version on IA? Hmmm, might watch that tonight. 🙂
Tuned in to The Matrix Resurrections the other day, not bad, although a…[Read more]

Got another one to be added to the issues list:
Function = CellUpdate
Options = 0x2000
Opcode = 0x1013
Return = 0x2, "None"
Desc = "Broken. Updates the current objects cell position."
End

It’s possible this is related to issue 4

This file is a long one and needs to have its extra newlines removed. Lot of pressing the DEL key 😛

In an ideal world, I’d like for it to use std::string for string types and char * (or whatever the current standard way of doing it is) for raw data blocks. If CString implements more than std::string then we may be able to simply create a subclass and go from there. Will add it to the list!

Still reformatting. Been on the script functions file…[Read more]

It’s a pain, CString is an object, TCHAR is a typdef macro that determines char_t types on MBCS (1 or 2 byte characters) or unicode build. CString should be easier to work with.
Sounds good. 🙂

project/EsmScriptFuncs.cpp defines short versions of the macros for the script functions and you can’t tell what the names mean at a glance. For an example, it defines 0 as VN and ESMSCR_FUNC_BYTE as VB. These should probably be changed to use the long form

I’ve spotted some stray symbols here and there so there may be some syntax errors that need to be resolved when we run things through a compiler. We’ll find out!

No idea why they chose that name! It’s definitely not water proof or large enough to take into the waves 😛

For me, I tend to use the aloe infused Irish Spring bar soap. Always has my skin feeling just right and I do like the subtle fragrance. 🙂

Robin sold the Nexus the other day. From the sounds of his post, he simply got burned out after…[Read more]

The script compiler has some form of support of an old version of MWSE. It’s not enabled by default and must be turned on at compile time. It may be worth having the MWSE devs take a look at those bits of code and seeing what kind of state it’s in.

That’s very cheap, why Boogie Board though – it’s a thing one paddles with at pools or at the beach – over here at least. OTOH one can aspire to be chairman of the board – chairman of the boogie board!
As a Xmas present, Lush’s Honey I Washed The Kids Shower Gel is one of the most pungent on the market. Suspect the citronellol, amyl cinnamal and…[Read more]

Decided on Attack of the Giant Leeches. Lot of fun but I fell asleep for a good portion due to exhaustion the last few weeks and not having gotten my regular naps in so I’ll need to give it another whirl soon. The costumes were suitably absurd with the requisite over-acting typical of Corman films. Great B-movie!

After the Yesterday Machine, may…[Read more]

project/EsmRecDialog.cpp and project/EsmRecDialog.h may be broken. It overrides GetControlData() but makes it an empty function so we’ll want to test that window to make sure everything works okay before I remove the empty override. From what I can, that class deals with adding a new record so that’s where we’ll want to look.

The producers might have considered teleporting the machine right into Hitler’s bunker in 1945. And the leeches don’t mean any harm whatsoever, they just want to help us all by enhancing anti-inflammatory, anticoagulant and antimicrobial effects. On a giant scale.
The lead teacher in Bad Teacher is really bad, so there’s a good chance of a giggle…[Read more]

Buffer.Format(_T("%d"), (int)(byte)pLongData->Strength);
Those lines can probably remove the byte cast as they just cast it to int before the variables are used anyways.

Yep, Tubi is a fun place!

Yep, seen Chopping Mall. It was pretty fun but I’m mostly out of killer robot films now 😛

Haven’t been watching too much lately, been doing a lot of reading, but I did catch Beneath the Planet of the Apes last week. Definitely not as good as the first film but was still pretty fun.

Going to add The Yesterday Machine…[Read more]