Reply To: MWEdit
We’ll want to update the build files to tell MSVC not to enable warnings for system header files. See: https://learn.microsoft.com/en-us/cpp/build/reference/external-external-headers-diagnostics?view=msvc-170
GCC and CLang handle this better and don’t issue them for system headers by default.
I also need to update the build files to mark some libraries as system headers. Will get there, still trying to get the code-base building. Sorting through more error logs at the moment.
Some of the files are complaining about a lack of forward declarations for classes they use even though we’re including the headers that set up the classes. We’ll definitely need to figure out why these errors are occurring but I’m re-adding the forward declarations for now, temporarily, until we figure it out. I suspect it may have something to do with the over use of macros but I’m not entirely sure.
Thus far, the complaints about the lack of classes being declared are from files where I removed the forward declarations.
Edit:
Looking it over, it looks like it may be due to the classes they need also needing them so more circular dependencies. Not much we can really do about that, I’m afraid, other than forward declarations. At least, I think so. Best I can do is just add them where the compiler complains, I guess.
We can probably ignore the part of the macros messing it up as it doesn’t appear to be case in this instance. Not to say they aren’t problematic, though.
