Reply To: MWEdit

Home Forums Projects MWEdit Reply To: MWEdit

#4788

git mv renames files and directories and git rm removes them from the repo. Once stuff is removed from Git, or renamed, it no longer shows up in the current state, just the historical state. 🙂

Yeah, it’s a bit of a mess. There are macro constants littered everywhere, including some duplicates, instead of being in a single place. That’s also on the list to take care of to make it easier to find everything.

I also want to set up a better way to handle versions but I keep second guessing myself. Here’s what I’ve been thinking: set it up so that we store the version numbers in variables in the GitHub Actions configuration, which are then passed to CMake. In the CMake script, we’d check to see if the variables are set and, if not, set them to 0. Then we run configure_file on a config.h.in file, setting up the variables for the headers and source files. Additionally, we do it for the resource files as well. If possible, we’d pass the variables to the file name for the archive upload to set up its final name. In this way, we could do version numbers all with a single edit.

Yep, the classes and such could use some work. That’s a future project since there’s quite a bit of stuff that needs to be done first.

There are also a few files with spelling errors and the general naming conventions aren’t followed in some cases so all of those should probably be corrected as well. I’m leaning towards having subdirectories in the esm/ directory (or whatever it winds up being called) for game specific stuff for when we finally bring in Dave’s other repos for other games, with the root being for common parameters. Of course, it may change down the road if I can resurrect my system of using config files to describe the file formats. That’s far future, however. Additionally, I’m leaning towards renaming the esm/ directory to game/ to represent the fact that it’s for game format support. How does that sound?