Reply To: MWEdit

Looks like Astyle missed the spacing around the parentheses for function parameters as well in addition to the pointer operands (I wonder if Uncrustify would have worked any better, didn’t think of it at the time) so I’m working on that now. This will take a bit as I need to go through each file and adjust things manually but we’ll get there! 🙂

Another item on the cleanup list is to clean up the returns. The return command is used inconsistently. Sometimes we see things like this:
return (true);
While other times we see this:
return true;
In some cases, the parentheses can be removed but will need to be done on a case-by-case basis to prevent the order of operations from getting messed up and giving us improper values. I’ll do that in a separate commit down the road. Side note: really wish we had syntax highlighting for the code tags. May look for a plugin for that at some point

There’s a mixture of boolean variable types from throughout the standard’s history: BOOL, boolean, and the current bool. bool is the current form and everything should probably be brought up to date to ensure the code will work across many different compilers and continue to work unless the variable is ever changed again in the future. Will add it to the list of things to do. I’m thinking of saving much of the overhaul until after the cpplint and cppcheck tasks are done as they’ll help with the initial pass and should help keep it from getting too overwhelming 🙂